Conversation
mumoshu
deleted the
fix-unsupported-protocol-schema-empty-docker-image-tags
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apparently the combination of the heroku/docker-registry-client library and Docker Hub is broken when interacting with Docker Hub. Docker Hub now returns relative URL paths in pagination Link headers instead of full URLs.
This causes the heroku library to fail with "unsupported protocol schema """ when fetching tags that span multiple pages, because the request URL for the second page lacks the protocol and host part (since the next link is relative).
This pull request adds our own client that properly handles relative URLs by resolving them against the base registry URL.