Fix ntfy JSON serialization by excluding URL and Token fields #167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The URL and Token fields were being included in the JSON payload sent to the ntfy server. Some ntfy servers reject requests with unknown fields in the JSON body, returning a 400 error: "invalid request: request body must be valid JSON" Adding `json:"-"` tags excludes these fields from serialization while keeping them available for the HTTP request configuration. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
json:"-"tags toURLandTokenfields in the ntfyNotificationstruct to exclude them from JSON serializationProblem
When sending notifications to ntfy, the
URLandTokenfields were being included in the JSON payload. Some ntfy servers (particularly self-hosted instances) reject requests containing unknown fields in the JSON body with:Solution
The
URLandTokenfields are only needed for HTTP request configuration (URL endpoint and Authorization header), not for the JSON body. Addingjson:"-"tags excludes them fromjson.Marshal()while keeping them available for the request.Test plan
go test ./service/ntfy/...passes🤖 Generated with Claude Code