Marking FederatedServiceRouter and FederatedServiceTokens as public #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #122 +/- ##
=======================================
Coverage 82.41% 82.41%
=======================================
Files 59 59
Lines 802 802
=======================================
Hits 661 661
Misses 141 141
🚀 New features to boost your workflow:
|
fpseverino
approved these changes
Sep 22, 2025
| package var errorKey: String { "error" } | ||
| public var codeKey: String { "code" } | ||
| public var errorKey: String { "error" } | ||
| package var callbackHeaders: HTTPHeaders { [:] } |
Member
There was a problem hiding this comment.
This doesn't need to be public?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Reasoning
This PR marks
FederatedServiceRouterandFederatedServiceTokensaspublicso that custom routers can be built.I have intentions to create a router for Apple Roster API authentication, and this change would allow others to create routers for any custom authentication they may need for their Vapor servers.
These were previously
publicin the Imperial package, and it was suggested that they could be madepublicagain in the Discord conversation here