Skip to content
This repository was archived by the owner on Nov 10, 2022. It is now read-only.

Conversation

@bit4bit
Copy link

@bit4bit bit4bit commented Feb 26, 2012

When i call
CommandSocket#command :show, :calls
it content is empty

but when i try

CommandSocket#command :show, :tasks
it has content

so, the problem was in Response#content= who do
@content = content.match(/:/) ? headers_2_hash(content) : content
this ok, but when the content, for example include.
....sip:1000@....

but in CommandSocket is a bug.

@ghost ghost assigned vangberg Feb 26, 2012
@vangberg
Copy link
Owner

Thank you. I need to revamp the CommandSocket tests. As soon as this is done I'll merge this in.

@pirj
Copy link
Contributor

pirj commented Aug 14, 2012

CommandSocket is evil and not EM aware (unless you monkeypatch TCPSocket). Same can be achieved using Listener::Inbound.

@vangberg
Copy link
Owner

CommandSocket still makes sense, in particular because it's not EM, it makes it simpler to use for e.g. one off scripts etc. Might rip it out in a separate gem, though.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants