WIP: Attempt to fix quasi-random UTF-8 conversion failures/seg faults

.github/workflows/ci_tests.yml

@@ -21,6 +21,7 @@ jobs:
       matrix:
         os: [ubuntu-latest, macos-latest]
         python-version: ['3.8', '3.9', '3.10', '3.11', '3.12']
+        tempo2-version: ['2021.07.1-correct', '2023.05.1', '2024.11.1', '2025.02.1']
 
     steps:
     - name: Checkout repository
@@ -34,11 +35,11 @@ jobs:
       run: |
         brew unlink gcc && brew link gcc
         brew install automake libtool
-        ./install_tempo2.sh
+        ./install_tempo2.sh -v ${{ matrix.tempo2-version }}
     - name: Install tempo2 on linux
       if: runner.os == 'Linux'
       run: |
-        ./install_tempo2.sh
+        ./install_tempo2.sh -v ${{ matrix.tempo2-version }}
     - name: Install dependencies and package
       run: |
         python -m pip install --upgrade pip

install_tempo2.sh

@@ -1,21 +1,46 @@
 #!/bin/bash -e
 
-# get install location
-if [ $# -eq 0 ]
-	then
-		echo 'No install location defined, using' $HOME'/.local/'
-		prefix=$HOME/.local/
-	else
-		prefix=$1
-		echo 'Will install in' $prefix
+# default Tempo2 version
+tempo2version="2021.07.1-correct"
+
+usage() { echo "Usage: $0 [-p <install-path>] [-v <tempo2-version>]" 1>&2; exit 1; }
+
+# default install location
+prefix=$HOME/.local/
+if [[ $# -eq 1 && "$1" != "-h" ]]; then
+    # interpret single argument as install location
+    prefix=$1
+    echo 'Will install in' $prefix
+else
+	# allow arguments
+	while getopts ":p:v:" o; do
+    case "${o}" in
+        p)
+            prefix=${OPTARG}
+            ;;
+        v)
+            tempo2version=${OPTARG}
+            ;;
+        *)
+            usage
+            ;;
+    esac
+done
 fi
 
+echo 'Will install in' $prefix
+echo 'Will attempt to install tempo2 version' $tempo2version
+
 # make a destination directory for runtime files
 export TEMPO2=$prefix/share/tempo2
 mkdir -p $TEMPO2
 
-curl -O https://bitbucket.org/psrsoft/tempo2/get/2021.07.1-correct.tar.gz
-tar zxvf 2021.07.1-correct.tar.gz
+dl=$(curl -Of https://bitbucket.org/psrsoft/tempo2/get/${tempo2version}.tar.gz || echo $?)
+if [ $dl -ne 0 ]; then
+    echo 'Version '${tempo2version}' of Tempo2 does not exist. Please see, e.g., https://github.com/mattpitkin/tempo2/tags for a list of allowed version tags.'
+    exit 1
+fi
+tar -zxvf ${tempo2version}.tar.gz
 
 cd psrsoft-tempo2-*
 
@@ -33,5 +58,5 @@ cp -r T2runtime/* $TEMPO2
 cd ..
 
 rm -rf psrsoft-tempo2-*
-rm -rf 2021.07.1-correct.tar.gz
+rm -rf ${tempo2version}.tar.gz
 echo "Set TEMPO2 environment variable to ${TEMPO2} to make things run more smoothly."