Add helm value extraEnvFromSecrets to metrics exporter in order to re…#133
Open
dpailer wants to merge 1 commit intovalkey-io:mainfrom
Open
Add helm value extraEnvFromSecrets to metrics exporter in order to re…#133dpailer wants to merge 1 commit intovalkey-io:mainfrom
dpailer wants to merge 1 commit intovalkey-io:mainfrom
Conversation
…ad the contents of a secret as environment variable in metrics exporter container Signed-off-by: dpailer <dirk.pailer@gmail.com>
|
Need this! |
Author
|
@dpailer @urbaman valkey-helm/valkey/values.yaml Line 325 in 2f9be3b disregard - although you can specify extra secrets for the exporter, you can't actually use them since there's no way to reference them in the extraEnvs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ad the contents of a secret as environment variable in metrics exporter container
e.g. if the secret contains the contents like
these will be available in a secure way for the redis exporter