feat: permit disable of persistence with replica mode#120
Open
yoannrt wants to merge 3 commits intovalkey-io:mainfrom
Open
feat: permit disable of persistence with replica mode#120yoannrt wants to merge 3 commits intovalkey-io:mainfrom
yoannrt wants to merge 3 commits intovalkey-io:mainfrom
Conversation
Signed-off-by: yoann_rt <65339843+yoannrt@users.noreply.github.com>
|
It would be great to get this merged. Thanks @yoannrt |
Collaborator
|
Thanks, can you please add test cases (default behavior leads to missing storage size, if size provided it renders the claim template, if disabled, emptyDir is used, etc.)? |
Signed-off-by: yoann_rt <65339843+yoannrt@users.noreply.github.com>
Signed-off-by: yoann_rt <65339843+yoannrt@users.noreply.github.com>
Contributor
Author
|
Hi @sgissi, ok done. Please let me know if you see something that is missing, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue-110
Allow disabling of pvc in replicamode when persistence of data is not required.