feat: Add PodDisruptionBudget support with configuration options#106
Open
SweetOBurritO wants to merge 4 commits intovalkey-io:mainfrom
Open
feat: Add PodDisruptionBudget support with configuration options#106SweetOBurritO wants to merge 4 commits intovalkey-io:mainfrom
SweetOBurritO wants to merge 4 commits intovalkey-io:mainfrom
Conversation
sgissi
reviewed
Dec 23, 2025
Collaborator
sgissi
left a comment
There was a problem hiding this comment.
Amazing work @SweetOBurritO, thanks for the PR. A few nitpicks in my review below, nothing major. Have you already tested that PDB works as intended for both min and max settings?
Author
|
@sgissi Updated the PR to address your feedback, simplified the documentation and fixed the values comments. |
Signed-off-by: Jarred Channer <jarredchanner@gmail.com>
…tion Signed-off-by: Jarred Channer <jarredchanner@gmail.com>
Signed-off-by: Jarred Channer <jarredchanner@gmail.com>
Signed-off-by: Jarred Channer <jarredchanner@gmail.com>
Contributor
|
Looking forward to have this feature merged in 🙏 |
Author
|
Hi @sgissi , just checking in on this PR, I know maintainers are often busy, so no rush. Would you mind letting me know if there’s any feedback, changes, or additional info needed from my side to help move this forward? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for configuring a Kubernetes PodDisruptionBudget (PDB) for Valkey replica deployments, enhancing high availability during voluntary disruptions (such as node drains or rolling updates) requested in #105 . The changes include new configuration options, Helm template logic, documentation updates, schema validation, and comprehensive tests.
PodDisruptionBudget support for high availability:
podDisruptionBudgetconfiguration block invalues.yamlto allow enabling/disabling PDB, settingminAvailableormaxUnavailable, and specifyingunhealthyPodEvictionPolicyfor Valkey replicas.values.schema.jsonto validate the newpodDisruptionBudgetfields, supporting both integer and percentage values forminAvailableandmaxUnavailable, and restrictingunhealthyPodEvictionPolicyto valid options.poddisruptionbudget.yamlthat conditionally generates a PDB resource when bothpodDisruptionBudget.enabledandreplica.enabledare true, applying the configured settings and selector labels.Documentation updates:
README.mdexplaining how to enable and configure PodDisruptionBudget, including usage examples and important notes about its behavior.README.mdto document the newpodDisruptionBudgetfields and their purposes.Testing:
poddisruptionbudget_test.yamlwith comprehensive cases to verify correct PDB creation, field precedence, value types, label propagation, and custom name overrides.