Skip to content

Comments

added typography and applied it to connection, dashboard and primitives#228

Merged
nassery318 merged 6 commits intomainfrom
typography-implementation
Feb 23, 2026
Merged

added typography and applied it to connection, dashboard and primitives#228
nassery318 merged 6 commits intomainfrom
typography-implementation

Conversation

@nassery318
Copy link
Contributor

Description

Include a summary of the change.

  1. Added custom Inter font
  2. Define named typography roles — text-heading, text-body-xs, text-code
  3. Applied the typography using a centralized Typography component

Change Visualization

Include a screenshot/video of before and after the change.

image

Signed-off-by: nassery318 <nassery318@gmail.com>
Signed-off-by: nassery318 <nassery318@gmail.com>
Signed-off-by: nassery318 <nassery318@gmail.com>
<Link
className="hover:underline"
style={{
overflow: "hidden",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not className block truncate?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed inline styles.

bodyXs: "p",
caption: "span",
overline: "span",
code: "code",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code is inline, so I guess we're missing a code block that should come with pre

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

codeBlock added for pre


/* Font */
--font-sans: 'Inter Variable', system-ui, -apple-system, 'Segoe UI', sans-serif;
--font-mono: ui-monospace, 'SF Mono', Consolas, monospace;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we need a custom monospace font too? ui-monospace will be an OS's font which will render differently on Windows and Mac and Linux, i.e. some of them are larger than others

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added the custom geist-mono for keeping the mono text consistent for different OSs.

Signed-off-by: nassery318 <nassery318@gmail.com>
Signed-off-by: nassery318 <nassery318@gmail.com>
Signed-off-by: nassery318 <nassery318@gmail.com>
@nassery318 nassery318 merged commit df239b1 into main Feb 23, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants