Skip to content

Conversation

@steswinbank
Copy link
Contributor

Added settings.distanceFromEdge so the cross will stay at the same distance from the right edge of the text box when window size is changed.

Added settings.distanceFromEdge so the cross will stay at the same distance from the right edge of the text box when window size is changed.
@fk
Copy link

fk commented Apr 27, 2013

Thanks @steswinbank - this actually helps a lot in positioning the clear-href horizontally.

While your patch "hotfixes" my current problem, I really think removing the positioning code (or at least making it optional) would be the way to go – IMHO, the positioning of the clear-href should be done on the presentational layer, and I can't think of a reason not to do so (forgive me if I'm missing something here).

I'd also love a CSS-class on the wrapper-div (the one providing position:relative for the clear-href) as I'd like to give the input-element a padding-right equivalent to the width of the clear-href, but only when the clear-href is actually displayed … but that's another story (resulting from a usecase where the horizontal space for the input is very limited, and placeholder text is needed); if I find the time I might have a shot at this myself.

Thanks for the useful plugin and the patch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants