A bunch of code cleanups #88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mbaldessari
commented
Jan 27, 2026
mbaldessari
commented
- Fix typo
- Move default_vp_vault_policies to load_secrets_common
- Introduce a common subclass for load secrets and parse secrets
- Some cleanups now that python3.11 is the minimum version
- Cleanup some complex functions
- Split up _inject_field to make it more readable
- Drop a duplicate test and add a proper test for when onMissingValue is wrong
- Simplify code a bit
- Refactor _validate_secret() a bit
- Retrict python versions and clean up whitespace
- A couple of more linting warnings
It is defined to be the exact same in load_secrets_v2 and parse_secrets_v2
This eliminates a bunch of duplicated code
Simplify the code a bit and make use of match/case to make it all a bit more readable
We can now use >= python 3.11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.