Some tidying #23
Merged
Some tidying #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* overleaf.el (overleaf-read-cookies-from-firefox): Remove unused variable 'start-pos'. Use 'when-let*' instead of 'when-let'. (overleaf-context-size): Make docstring less than 80 characters. (overleaf--debug): Move defsubst before first use. (overleaf--get-cookies): Use 'if-let*' instead of 'if-let'. (overleaf--transform-edits): Remove unused variable 'delta'. (overleaf--completing-read): Use 'if-let*' instead of 'if-let'. (overleaf--extract-context-at-point): Use LENGTH argument instead of hardcoded value 10. (overleaf--row-col-to-pos): Use 'forward-line' instead of 'goto-line'. (overleaf--make-cursor-overlay): Use 'when-let*' instead of 'when-let'. (overleaf--update-cursor): Use 'when-let*' instead of 'when-let'. (overleaf--format-user-info): Add 'declare-function' for 'which-function'. (overleaf-find-file): Remove unused variable 'longest-name'. (overleaf-connect): Remove unused format string argument.
* README.org (Keybindings): Add example configuration for bibtex-mode.
Owner
|
I don't really see the point of using the starred version of if and when... |
Contributor
Author
|
Me neither; indeed, I prefer the aesthetics of the unstarred versions. Unfortunately, the unstarred versions are deprecated in Emacs 31+, so I get nuisance compiler warnings if we don't star them. I'm happy to switch them back if you'd prefer |
Owner
|
interesting... well, let's keep them then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Flycheck warnings and add docs for
bibtex-modebinds.