Unified Macro Definitions#83
Merged
vaivaswatha merged 30 commits intovaivaswatha:masterfrom Feb 13, 2026
Merged
Conversation
Owner
|
Looks totally fine to me. Thank you @rahulmutt . |
Contributor
Author
|
@vaivaswatha I've updated all the code to use the new macros where possible, except for files inside of |
rahulmutt
commented
Feb 13, 2026
| #[cfg_attr(not(target_family = "wasm"), ::pliron::linkme::distributed_slice(#interface_verifiers_slice), linkme(crate = ::pliron::linkme))] | ||
| static INTERFACE_VERIFIER: std::sync::LazyLock<(#id, (#all_verifiers_fn_type))> = | ||
| std::sync::LazyLock::new(|| | ||
| (#rust_ty::#get_id_static(), |
Contributor
Author
There was a problem hiding this comment.
Highlighting this as this also improves UX by not forcing users to import ::pliron::op::Op, or any of the other entity traits and keeps the macro generated code explicit.
Owner
There was a problem hiding this comment.
Thank you. I did encounter this myself, but without a second though just added the import. This makes it much better for new users.
vaivaswatha
approved these changes
Feb 13, 2026
Owner
|
Thank you @rahulmutt |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #58
It is mostly a straightforward change since it's a UX change that will translate to existing macros - actual functionality has not beed added or removed.
So far only the builtin dialect has been updated. After an initial review,
pliron-llvmand most of the tests will be updated.