Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change will reduce your node_modules on-disk footprint by 97%, from 2.3M to 80K.
The reason is that you ship in your package your tests and your test data, and you do have good tests with large test data samples... :P
tests files, dev-config files, docs and fixture data are not meant to be shipped in the package.
Current situation:
after change:
pacakge size reduces as well:
I'm not sure about
dist. Most web-apps do their own bundling and compacting...However, if you chose not to ship dist - you'll be breaking compatibility and should raise a major.