Skip to content

Conversation

@aman-coder03
Copy link

Adds missing French (fr) localization for Gabon (GA).

This introduces a new GA.po file with correct gettext structure
(English source strings with French translations), following existing
Francophone locale patterns.

fixes #3176.
Part of #3152.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 29, 2025

Caution

Review failed

Failed to post review comments

Summary by CodeRabbit

  • New Features

    • Gabon holidays now support French and English localization, with French as the default.
    • Holiday names and the "estimated" label are localized; new French and en_US translation catalogs added.
  • Tests

    • Added tests validating French and English holiday name translations for Gabon.

✏️ Tip: You can customize this high-level summary in your review settings.

Walkthrough

Adds French and en_US localization catalogs for Gabon (GA), updates the Gabon country class to set default and supported languages and wrap public holiday names with translations, and adds a test validating French localization.

Changes

Cohort / File(s) Summary
French localization PO
holidays/locale/fr/LC_MESSAGES/GA.po
New French translation catalog with PO headers and French msgstr translations for Gabon holiday names and phrases (e.g., "%s (estimated)", Independence Day variants).
en_US localization PO
holidays/locale/en_US/LC_MESSAGES/GA.po
New English (en_US) PO file with msgstr entries matching msgids and standard PO headers.
Gabon country implementation
holidays/countries/gabon.py
Added default_language = "fr" and supported_languages = ("fr", "en_US"); introduced tr alias and wrapped all public holiday name strings and estimated_label with tr(...).
Tests
tests/countries/test_gabon.py
Added test_l10n_default to assert French-localized holiday names for 2022.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

Suggested reviewers

  • arkid15r
  • KJhellico
  • PPsyrius

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adding French localization for Gabon holidays, which is clearly the primary focus of the changeset.
Description check ✅ Passed The description is relevant and explains the purpose of the PR, detailing that it adds French (fr) localization for Gabon with proper gettext structure and referencing related issues.
Linked Issues check ✅ Passed The PR implements all requirements from #3176: adds French holiday names and translations in GA.po, ensures consistency with existing Francophone locale patterns, and includes tests for the new localization.
Out of Scope Changes check ✅ Passed All changes are directly in scope. The PR adds French translations (GA.po files), updates gabon.py with i18n support and language metadata, and includes a localization test—all aligned with issue #3176.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@KJhellico KJhellico marked this pull request as draft December 29, 2025 10:27
@github-actions github-actions bot added the test label Dec 29, 2025
@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add French (fr) localization for Gabon (GA)

1 participant