Skip to content

Fix issue preventing BPH below 14400 from working #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xyzzy42 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix issue preventing BPH below 14400 from working #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e1e4367
Fix issue preventing BPH below 14400 from working
xyzzy42 Feb 13, 2021
5fa7289
Lower min BPH to 8100
xyzzy42 Apr 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/algo.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -898,15 +898,20 @@ static void compute_cal(struct calibration_data *cd)
void process(struct processing_buffers *p, int bph, double la, int light)
{
prepare_data(p, !light);

p->ready = !compute_period(p,bph);
if(p->ready && p->period >= p->sample_rate / 2) {
/* Limit to 20% greater when period is known, or 500 ms when guessing period */
const int min_bph = bph ? bph : TYP_BPH;
const int max_period = (int)(1.2 * 3600 * 2) * p->sample_rate / min_bph;
if(p->ready && p->period >= max_period) {
debug("Detected period too long\n");
p->ready = 0;
}
if(!p->ready) {
debug("abort after compute_period()\n");
return;
}

prepare_waveform(p);
p->ready = !compute_parameters(p);
if(!p->ready) {
Expand Down
3 changes: 2 additions & 1 deletion src/tg.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,8 @@
#define PAPERSTRIP_ZOOM_CAL 100
#define PAPERSTRIP_MARGIN .2

#define MIN_BPH 12000
#define MIN_BPH 8100
#define TYP_BPH 12000
#define MAX_BPH 72000
#define DEFAULT_BPH 21600
#define MIN_LA 10 // deg
Expand Down