Add checks to RawGhostFile #254
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FallBackITA27
changed the title
malleoz
requested changes
Feb 16, 2025
| @@ -1,9 +1,12 @@ | |||
| build | |||
| build.ninja | |||
| compile_commands.json | |||
Collaborator
There was a problem hiding this comment.
Can you clarify where these files are coming from? I'm not sure if these need to be added to the .gitignore. Even if they should be added, I think this doesn't pertain to the scope of this PR
Author
There was a problem hiding this comment.
Zed forces clangd down your throat and this is the only way to prevent it :P if .vscode is gitignored then so should these really.
FallBackITA27
force-pushed
the
rkg-is-valid
branch
from
f4153db to
4d85ff2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Finish Time, Lap Number and Controller ID checks to
RawGhostFile::IsValid()