Open
Conversation
…ly undefined' error in strict mode (ngrx#2876)
Exclude node_modules from being visited
…ngrx#2885) * feat(store): add object-style StoreModule.forFeature overload (ngrx#2821) Closes ngrx#2809 * fix(store): update StoreModule to be compliant with AOT Co-authored-by: Suguru Inatomi <suguru.inatomi@gmail.com>
) The deprecated function 'empty()' is replaced with 'EMPTY' object. Closes ngrx#2891
…rx#2906) TypeScript only recognizes the overloads as method signatures when being overloaded not the actual implementation, added overload for the case where isOptimistic is true or undefined (default for entity). This will allow for the following: `.add(entityWithoutId, { isOptimistic: false })` `.add(entityWithId, { isOptimistic: true })` `.add(entityWithId, { // any other options without whatever settings and no explicit value for isOptimistic })` `.add(entityWithId)`
BREAKING CHANGE: The minimum TypeScript version has been updated to 4.1.x BEFORE: The minimum TypeScript version is 4.0.x AFTER: The minimum TypeScript version is 4.1.x
BREAKING CHANGES: Minimum versions of Angular and TypeScript have been updated BEFORE: Minimum of Angular version 11.x Minimum of TypeScript 4.1.x AFTER: Minimum of Angular version 12.x Minimum of TypeScript 4.2.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Allow to specify custom prefix for the action
What is the current behavior?
Closes #
What is the new behavior?
Does this PR introduce a breaking change?
Other information