Register indicator action as secondary activation target#331
Open
dshoreman wants to merge 2 commits intov1cont:masterfrom
Open
Register indicator action as secondary activation target#331dshoreman wants to merge 2 commits intov1cont:masterfrom
dshoreman wants to merge 2 commits intov1cont:masterfrom
Conversation
Replaces the "Activate" menu item with a secondary target that calls the `action`/`--command` when middle-mouse is clicked.
Restores middle-click-quit by default (unless `--no-middle` is set) and removes the automatic Quit menu item to restore original --notification behaviour and avoid existing menus getting duplicated Quit items.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new
--indicatormode works great with Waybar, but it always creates an "Activate" and "Quit" item - even if you already have your own. This PR brings behaviour closer to the notification mode:quitifactionand--no-middleare both undefinedIf you'd rather keep a default Quit menu item, I have another commit to push - just say the word.
It would avoid duplication (essentially
add-unless any d.action == ('quit' || 'kill *'), but it can't support "no quit". For that it'd need a new option like--no-quit-itemso it's probably easier to keep letting users add it.