Fix text label sizing with --width and --geometry#318
Open
mg-dev25 wants to merge 1 commit intov1cont:masterfrom
Open
Fix text label sizing with --width and --geometry#318mg-dev25 wants to merge 1 commit intov1cont:masterfrom
mg-dev25 wants to merge 1 commit intov1cont:masterfrom
Conversation
Fixes window sizing issues when using --width, --geometry, or --wrap options with long text content. Without this fix, GTK requests the natural (unwrapped) width first, causing windows to become excessively large. Changes: - Add text_size_allocate_cb() callback to constrain label width - Set PANGO_WRAP_WORD_CHAR mode for better word breaking - Use max_width_chars with ELLIPSIZE_NONE to force wrapping - Connect size-allocate signal when width is constrained Fixes v1cont#107, v1cont#140, v1cont#32, v1cont#297, v1cont#300
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix text label sizing with --width and --geometry
Fixes window sizing issues when using
--width,--geometry, or--wrapoptions with long text content.Fixes #107, #140, #32, #297, #300
Problem
When a dialog has long text and
--widthis specified, GTK requests the natural (unwrapped) width first, then tries to wrap the text. This causes windows to expand far beyond the requested width.Solution
Added a
size-allocatecallback that constrains the label width to the allocated space. Also setmax_width_charswithELLIPSIZE_NONEto force text wrapping instead of window expansion.Changes in
src/main.c:text_size_allocate_cb()callbackPANGO_WRAP_WORD_CHARmode for better word breakingmax_width_charsbased on window widthsize-allocatesignal when width is constrainedTesting