refactor: prototype for D3-based native wordcloud#5010
refactor: prototype for D3-based native wordcloud#5010jabbadizzleCode merged 4 commits intowordcloudfrom
Conversation
Co-authored-by: Codex
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (4)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@jabbadizzleCode I had Codex 5.3 do some prototyping for how our own "word-cloud" package could be structured/look like. We should try this and think about how well it maps to our use case :) |
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
Context / Why
This PR starts replacing the legacy
react-wordcloudintegration with a native D3 implementation.The current renderer dependency is outdated for the current stack (React 19 monorepo) and limits maintainability and control over layout/render behavior. The goal is to migrate in stages while preserving the existing evaluation UX contract.
What Was Implemented
@klicker-uzh/word-cloud/Users/rolandschlaefli/.codex/worktrees/eaff/klicker-uzh/packages/word-cloud/src/layout.ts/Users/rolandschlaefli/.codex/worktrees/eaff/klicker-uzh/packages/word-cloud/src/render.ts/Users/rolandschlaefli/.codex/worktrees/eaff/klicker-uzh/packages/word-cloud/src/random.ts/Users/rolandschlaefli/.codex/worktrees/eaff/klicker-uzh/packages/word-cloud/src/types.ts/Users/rolandschlaefli/.codex/worktrees/eaff/klicker-uzh/packages/word-cloud/src/index.tscomputeWordCloudLayout(words, options): LayoutResultrenderWordCloud(container, layoutResult, renderOptions): RendererHandleRendererHandle.update(nextLayoutResult)/RendererHandle.destroy()/Users/rolandschlaefli/.codex/worktrees/eaff/klicker-uzh/packages/word-cloud/demo/index.html/Users/rolandschlaefli/.codex/worktrees/eaff/klicker-uzh/packages/word-cloud/demo/main.js/Users/rolandschlaefli/.codex/worktrees/eaff/klicker-uzh/packages/word-cloud/demo/server.mjs/Users/rolandschlaefli/.codex/worktrees/eaff/klicker-uzh/packages/word-cloud/test/layout.test.ts/Users/rolandschlaefli/.codex/worktrees/eaff/klicker-uzh/packages/shared-components/src/charts/ElementWordcloud.tsx/Users/rolandschlaefli/.codex/worktrees/eaff/klicker-uzh/packages/shared-components/src/charts/NativeD3WordCloud.tsx/Users/rolandschlaefli/.codex/worktrees/eaff/klicker-uzh/packages/shared-components/package.json/Users/rolandschlaefli/.codex/worktrees/eaff/klicker-uzh/pnpm-lock.yaml/Users/rolandschlaefli/.codex/worktrees/eaff/klicker-uzh/turbo.json/Users/rolandschlaefli/.codex/worktrees/eaff/klicker-uzh/cypress/cypress/e2e/O-live-quiz-workflow.cy.tsBehavior Preserved
'42')log,archimedean)0/-90) and single-word rotation behaviorElementWordcloudprops contractWhat Remains (Next Migration Steps)
Validation
Executed successfully in this branch:
pnpm --filter @klicker-uzh/word-cloud checkpnpm --filter @klicker-uzh/word-cloud testpnpm --filter @klicker-uzh/word-cloud build/and/dist/index.js) with render + tooltip behavior verifiedKnown Issue / Follow-Up
Check syncpack conformityis currently failing and reportspackages/shared-components/package.jsonfor follow-up.Follow-Up Artifact
Migration status is now tracked in:
/Users/rolandschlaefli/.codex/worktrees/eaff/klicker-uzh/project/WORDCLOUD_NATIVE.mdproject/WORDCLOUD_NATIVE.md(commit7621a6d36)This document tracks migration goals, concepts, completed steps, and open tasks until full native migration is complete.