Update the Android app #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Target API 34. Remove lots of extra code, refactor parts of the app to simplify the logic. Update the UI to support both landscape and portrait orientations and add a proper loading skeleton. Update to latest Kotlin, Compose and Jetpack libraries. Remove extra dependencies. Remove tests as we're not using them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Target API 34. Remove lots of extra code and refactor parts of the app to simplify the logic. Update the UI to support landscape and portrait orientations and add a proper loading skeleton. Update to the latest Kotlin, Compose, and Jetpack libraries. Updated the notification player to only display the progress bar (unseekable), removing extra buttons, which didn't work anyway. Remove extra dependencies. Remove tests as we're not using them. The version is now 2.0.0 (versionCode 200)
Tested on the following Android emulators:
The app should perform much better now. Please test (if you can) before merging.