Conversation
Member
|
We chose -O1 so that we'd still get inlining in debug mode. I thought there used to be build/correctness problems; that may have been with an old compiler or with an incorrect use of includes, since these days things seem to run okay There is a significant performance difference, as you can see from this 15-node, 8-core-per-node demo-gups4 run (both sizeA and sizeB 2^30):
I think that performance gap is too large to make -O0 the default in debug mode, but we could add a switch to the build. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems that things build fine with O0, so why not use it for debugging instead of O1?