Update to uwwptheme

[tifsev]

This adapts the plugin to the UW WP Theme.

To test, pull down branch and run npm install. Then run gulp. The site should launch.

Check out the thinstrip navbar and make sure the social icons are present. I used wordpress dashicons instead of font awesome. (These did not work on localhost but are working on multisite?)

Test the select dropdowns. Inspect them in the developer tools. You should see a for="" attribute in the <label> element that connects to the select ID below.

NOTE: I am getting a console error --

Uncaught TypeError: Cannot read properties of null (reading 'dataset') at 2014.min.js?ver=3.7:5:566 which is searchSite = searchArea.dataset.search. Since it's pulling from the theme, I'm not sure how best to address this. Fix in theme?

[tjsuw]

I am running into some issues getting this going. I know some of it is because my import went poorly so I don't have everything set up. Here is what I'm seeing on the 2022 page, which is mostly working. The header is pushed down and the social icons are missing (though I see dashicons references in the inspector).

But then on the home page I am seeing (specifically look where the social icons should be):

Notes:

• I have UW WP Theme active
• I do not have Template Hierarchy active and it's not loading anything in
• I ran npm i and gulp on both node 20 and node 14 just to be sure

Is there anything else I need to do for setup? Any ideas what might be happening?

I see that console error on sites occasionally. I think it's on Boundless for example. I do think we should fix it in the theme. Let's add it to the backlog if it's not already there. I'm guessing there is a check missing because some sites don't have that option.

[tifsev]

@tjsuw, I can see the dashicons if l'm logged in -

But if I'm not logged in, they are empty. So I'll have to change those to font awesome.

As for the header being pushed down, I have a check for if you're logged in, the thinstrip to be pushed down. I can't recreate that problem when I'm not logged in. Maybe somehow related to the dashicons?

[tjsuw]

Oh that's weird. I was logged in but I don't have the bar (I turn it off). So that explains why the thinstrip is pushed down. But doesn't make sense for the missing icons. I guess switching to font awesome is the right way to go. I remember you mentioned the FB icon isn't the right one - I think it's OK if it's not the same. We can easily explain why had to swap the icons and this one is different.

[tifsev]

@tjsuw I have changed the icons to font awesome. However, there seem to be filter problems with the Year filter. Hold off reviewing again for now.

[tjsuw]

@tjsuw I have changed the icons to font awesome. However, there seem to be filter problems with the Year filter. Hold off reviewing again for now.

I see a commit from after this comment. Am I still holding or is it ready for a look?

[tifsev]

@tjsuw Ok, it should be good to go now!

[tjsuw]

The icons are working for me now - thank you! I don't know what was happening with the year filter but it appears to be working as expected, too.

I spotted a few minor things and then some questions came up upon further digging.

A few small tweaks:

• Let's not push down the thinstrip if you're logged in
• Can we easily get the arrows back on the header buttons? (The about and blog ones) And maybe only show the underline on hover/active/etc.?
• I noticed when tabbing through that there is a blue border and box shadow on the menu items in the thinstrip. Our theme purple border is also there, which is good. Can we get rid of the blue? I see it on the live site too so I'm guessing it's being added in the plugin.
• For the audience menu, can we mimic what we do in the theme with the underline only showing on hover? The change from gray to purple alone might be too subtle. (just the words, not the icons. I like the icons expanding on hover!)
• When looking at a profile, the tags are really light on hover - I think they might be the light gold. Can we either change the hover color or change the text color for those?
• I reran the axe devtools scan and a small number of issues are still coming up - they should be super quick fixes!

How does the blog look? I wasn't able to import the posts so I'm curious what you're seeing there.

Poking around at the other pages, it looks like there are some announcement pages where there is a table of the names with some of their information. Here's an example from the live site. The tables appear unstyled on my local site. Are you seeing any styling? If not, let's either get the styling into the stylesheet or make a note to update the table html to add the bootstrap classes when we update the site to get them looking a little nicer.

Oh I just realized these pages also have sidebars with widgets in them! Let's make sure those still look like they should (or close to it).

Can you look into adding a bit of code to close the profile if it's open and you press the escape key? You can navigate through well with the keyboard except for closing a profile.