pgrep, pkill: Unify process matching code #322
Merged
cakebaker merged 4 commits intouutils:mainfrom Feb 14, 2025
Merged
Conversation
Also move construction of Settings into its own function.
Requires adding require_handler to Settings.
dezgeg
force-pushed
the
pgrep_pkill_unification2
branch
from
9c2c845 to
eef5fab
Compare
The process matching logic for pgrep and pkill is identical, extract it to a common module.
dezgeg
force-pushed
the
pgrep_pkill_unification2
branch
from
eef5fab to
ba00e9c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #322 +/- ##
===========================
===========================
☔ View full report in Codecov by Sentry. |
Contributor
|
Nice refactoring, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After previous changes the process matching part in pgrep and pkill are identical. Extract it into a common module for both.