Conversation
|
Could you please add a test to make sure we don't regress? Thanks |
Added |
cakebaker
left a comment
There was a problem hiding this comment.
Looks good.
I noticed a small difference to the original pidof, though: it lists the IDs in a descending order whereas we use an ascending order:
$ pidof konsole -t
26231 26230 26229 26228 1365 1364 1363 1362 1361
$ cargo run -q pidof konsole -t
1361 1362 1363 1364 1365 26228 26229 26230 26231
Without the -t flag, both use a descending order.
This flag makes pidof print thread ids of threads belonging to the matching processes.
Good catch, also found out that |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #318 +/- ##
===========================
===========================
☔ View full report in Codecov by Sentry. |
This flag makes pidof print thread ids of threads belonging to the matching processes.