Skip to content

feat: uploadDirectory method#136

Closed
ChiragAgg5k wants to merge 6 commits into0.18.xfrom
feat-uploadDirectory
Closed

feat: uploadDirectory method#136
ChiragAgg5k wants to merge 6 commits into0.18.xfrom
feat-uploadDirectory

Conversation

@ChiragAgg5k
Copy link
Copy Markdown
Member

No description provided.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Sep 12, 2025

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat-uploadDirectory

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ChiragAgg5k ChiragAgg5k requested a review from Copilot September 12, 2025 13:18
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new uploadDirectory method to the storage device framework, enabling batch upload of entire directories to storage devices. The feature supports both recursive and non-recursive directory uploads with proper error handling.

  • Adds abstract uploadDirectory method to the base Device class with configurable recursion
  • Implements the method for Local and S3 storage devices with appropriate file handling
  • Adds comprehensive test coverage for both Local and S3 storage implementations

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/Storage/Device.php Adds abstract uploadDirectory method definition to base Device class
src/Storage/Device/Local.php Implements uploadDirectory for local file system with copy operations
src/Storage/Device/S3.php Implements uploadDirectory for S3 storage using existing upload method
src/Storage/Device/Telemetry.php Adds telemetry wrapper for uploadDirectory method calls
tests/Storage/S3Base.php Adds test case and abstract getAdapterType method for S3 implementations
tests/Storage/Device/LocalTest.php Adds test case for Local device uploadDirectory functionality

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants