-
Notifications
You must be signed in to change notification settings - Fork 84
Feat: Adds game-specific save location symlink support #441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
joshuatam
wants to merge
3
commits into
utkarshdalal:master
Choose a base branch
from
joshuatam:feat/symlink-gamesave
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+108
−6
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
42 changes: 42 additions & 0 deletions
42
app/src/main/java/app/gamenative/enums/SpecialGameSaveMapping.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| package app.gamenative.enums | ||
|
|
||
| /** | ||
| * Configuration for game-specific save location mappings | ||
| * | ||
| * This data class defines how to create symlinks for games that store saves | ||
| * in non-standard locations or need compatibility mappings. | ||
| * | ||
| * @property appId The Steam app ID | ||
| * @property pathType Which PathType to use as the base path (e.g., WinAppDataLocal, WinMyDocuments) | ||
| * @property sourceRelativePath Relative path from the base path to the actual save location | ||
| * @property targetRelativePath Relative path where the symlink should be created | ||
| * @property description Human-readable game name for logging | ||
| * | ||
| * Supports placeholders in paths: | ||
| * - {64BitSteamID} - Replaced with the user's 64-bit Steam ID | ||
| * - {Steam3AccountID} - Replaced with the user's Steam3 account ID | ||
| */ | ||
| data class SpecialGameSaveMapping( | ||
| val appId: Int, | ||
| val pathType: PathType, | ||
| val sourceRelativePath: String, | ||
| val targetRelativePath: String, | ||
| val description: String | ||
| ) { | ||
| companion object { | ||
| /** | ||
| * Registry of game-specific save location mappings | ||
| * Add new entries here for games that need save folder symlinks | ||
| */ | ||
| val registry = listOf( | ||
| SpecialGameSaveMapping( | ||
| appId = 2680010, | ||
| pathType = PathType.WinAppDataLocal, | ||
| sourceRelativePath = "The First Berserker Khazan/Saved/SaveGames/{64BitSteamID}", | ||
| targetRelativePath = "BBQ/Saved/SaveGames", | ||
| description = "The First Berserker Khazan" | ||
| ) | ||
| // Add more game mappings here as needed | ||
| ) | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P2: Missing
PrefManagerfallback for Steam ID retrieval. Other functions in this file (e.g.,ensureSteamSettings) checkPrefManager.steamUserSteamId64andPrefManager.steamUserAccountIdas fallbacks before defaulting to "0". Without this fallback, symlinks could be created with "0" in the path when the Steam ID is temporarily unavailable fromSteamService.(Based on your team's feedback about adding fallbacks when reading optional data.)
View Feedback
Prompt for AI agents