-
Notifications
You must be signed in to change notification settings - Fork 84
feat: UI/UX Overhaul #395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ObfuscatedVoid
wants to merge
4
commits into
utkarshdalal:master
Choose a base branch
from
ObfuscatedVoid:feat/ui-ux-overhaul
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+12,989
−3,710
Open
feat: UI/UX Overhaul #395
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
0382d20
chore: add kls_database.db to .gitignore
ObfuscatedVoid ed0225a
feat: add input prompt icons for keyboard and gamepad
ObfuscatedVoid c68b394
feat: design BootingSplash with animations and progress indicators
ObfuscatedVoid d399dd4
feat: implement connection state management, improve controller navig…
ObfuscatedVoid File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -41,6 +41,7 @@ app/.cxx/ | |
| # Kotlin 2.0 | ||
| .kotlin/sessions | ||
| *.salive | ||
| kls_database.db | ||
|
|
||
| # Signing Configs | ||
| *.jks | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| # Third-Party Notices | ||
|
|
||
| This file contains notices for third-party assets and libraries used in this project. | ||
|
|
||
| --- | ||
|
|
||
| ## Kenney Input Prompts | ||
|
|
||
| **Asset Pack:** Input Prompts | ||
| **Author:** Kenney (https://kenney.nl) | ||
| **Source:** https://kenney.nl/assets/input-prompts | ||
| **License:** CC0 1.0 Universal (Public Domain) | ||
|
|
||
| The input prompt icons used for gamepad, keyboard, and mouse button indicators | ||
| are from Kenney's Input Prompts asset pack. These icons are located in: | ||
| - `app/src/main/res/drawable/ic_input_xbox_*.xml` (Xbox controller icons) | ||
| - `app/src/main/res/drawable/ic_input_kbd_*.xml` (Keyboard and mouse icons) | ||
|
|
||
| While CC0 doesn't require attribution, we gratefully acknowledge Kenney's | ||
| excellent work in creating these assets. | ||
|
|
||
| --- | ||
|
|
||
| ## License Text: CC0 1.0 Universal | ||
|
|
||
| The person who associated a work with this deed has dedicated the work to the | ||
| public domain by waiving all of his or her rights to the work worldwide under | ||
| copyright law, including all related and neighboring rights, to the extent | ||
| allowed by law. | ||
|
|
||
| You can copy, modify, distribute and perform the work, even for commercial | ||
| purposes, all without asking permission. | ||
|
|
||
| Full license text: https://creativecommons.org/publicdomain/zero/1.0/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll have to get some testing on a few different devices to make sure this functionality works here 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This mostly feels like a hack, but the only way I could get it to consistently stay full screen. I have a hard time believing there isn’t a better way.