Replace Student Table Slug Values with ULIDs #188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
betsyecastro
added
✨ enhancement
… ULID in the students table
betsyecastro
added
🗃️ needs-migration
shukla-m
reviewed
Apr 10, 2025
| */ | ||
| public function updateStudent(Student $student): void | ||
| { | ||
| $existing_student = DB::table('students')->where('id', $student->id) ?? null; |
There was a problem hiding this comment.
The $existing_student retrieval/update can probably be skipped, while updating the $student instance directly:
$student?->update(['slug' => Str::ulid()]);
shukla-m
requested changes
Apr 10, 2025
shukla-m
left a comment
shukla-m
left a comment
There was a problem hiding this comment.
@betsyecastro I pulled in the changes and tested locally and it seems to work as expected.
- Please see notes on suggestion for a minor change in the seeder code.
- I tested a user's bookmarks, and the bookmarked links work if they reload the bookmarks page after the migrations/seeder are run, otherwise they get a 404 error for a bookmark link, since the
slugis changed. - Also, as I mentioned when we met, since there are multiple steps in the migration/seeder, wrapping the steps in a database transaction might make it more robust, so that it can be rolled back in case of failure.
Please let me know if you have any questions or need additional information. Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds seeder to replace current slug values for the student table with a ULID.
Generates a ULID for new student records.