Conversation
kvsikand
reviewed
Jul 30, 2021
| @@ -0,0 +1,19 @@ | |||
| { | |||
Collaborator
There was a problem hiding this comment.
I don't think this file needs to be included
| @@ -0,0 +1,10 @@ | |||
| { | |||
| example_robot | ||
| ) | ||
|
|
||
| ## System dependencies are found with CMake's conventions |
Collaborator
There was a problem hiding this comment.
we can probably clean up the commented out sections of this CMakeLists? It looks like this is copied from a template so maybe its fine to leave as-is though
| <version>0.0.0</version> | ||
| <description>The robofleet_status package publishes status messages to the Robofleet Webviz</description> | ||
|
|
||
| <!-- One maintainer tag required, multiple allowed, one person per tag --> |
Collaborator
There was a problem hiding this comment.
again, maybe we should clean up the commented out portions of this file
kvsikand
requested changes
Oct 7, 2021
Collaborator
kvsikand
left a comment
kvsikand
left a comment
There was a problem hiding this comment.
This would be really helpful to merge in! If we clean up some of these extra files I'm all for it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wrote a traditional ROS pkg that can be built in a catkin workspace. Many users are running packages from inside a catkin workspace - this example is provided to get users publishing to the webviz faster using the ideal rosnode setup, instead of python scripts.