USWDS-Compile: Support configuring sass-embedded #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add `sassOptions` to `settings.compile`.
- Include type hints from `sass-embedded` Options. Until
`@types/gulp-sass` is updated for v6, this is more correct than
using `GulpSassOptions` from `@types/gulp-sass` which is based on
`node-sass`.
- Indicate default options that will apply unless overridden.
- Deprecate (but still support) `sassDeprecationWarnings`.
- Include JSDoc deprecation notice.
- Better support SASS option `style` when set to `expanded` to avoid
running CSSO minification. This improves source map reliability.
mdmower-csnw
commented
Feb 6, 2025
- Watch `loadPaths` for changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request builds on top of #159. Once that pull request is merged into
develop, this PR will be updated and those changes will disappear from the file changes.Summary
Add support for configuring
sass-embeddedoptions. This improves this flexibility ofuswds-compilefor consumers.sassOptionstosettings.compile.sass-embeddedOptions. Until@types/gulp-sassis updated for v6, this is more correct than usingGulpSassOptionsfrom@types/gulp-sasswhich is based onnode-sass.loadPathsare defined, watch these paths for changes when thewatchscript is running.sassDeprecationWarnings.stylewhen set toexpandedto avoid running CSSO minification. This improves source map reliability.Related issue
Closes #133
Closes #80
Closes #59
Testing and review
A testing pull request has been prepared for the sandbox: uswds/uswds-sandbox#180 . Sample tests to get you started are included in that PR description.