Moved link to bootstrap.css to the init function#6
Open
SteveX wants to merge 2 commits intoussher:masterfrom
Open
Moved link to bootstrap.css to the init function#6SteveX wants to merge 2 commits intoussher:masterfrom
SteveX wants to merge 2 commits intoussher:masterfrom
Conversation
Linking to the bootstrap css in the meta.tpl prevents css_embed from being able to override styles. So this commit just adds the styles to the skin init function, and provides the correct url for the fonts in the bootstrap.css itself
Contributor
Author
|
Would it be useful to add the seperate bootstrap stylesheets? Then chunks of unused css could be commented out in the init function - it's quite useful for making clear which rules are used for what when getting your head around bootstrap. The same with the js files - a list of separate js files rather than the one combined one? |
Contributor
Author
|
I removed the link to the carousel stylesheet and didn't add it back into the init function, don't think it is in use? |
Owner
There was a problem hiding this comment.
Wont this make it necessary to update any bootstrap.css files that come out. not just copy+paste?
Contributor
Author
There was a problem hiding this comment.
Yes, if you use the icons and are unable to override rules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linking to the bootstrap css in the meta.tpl prevents css_embed from
being able to override styles. So this commit just adds the styles to
the skin init function, and provides the correct url for the fonts in
the bootstrap.css itself