Feature/full maven build #76
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* creating a jsip folder for parent pom with modules * creating clean java project structure with maven * moving source code to new structure * moving unit tests to new structure * compilation and build ok * fix few unit tests that crashes
* adding tools as project of their own * adding missed unit test on sdp on jain-sip-ri
* moving examples classes to an examples project
* moving TCK to test suite component * moving testcases from RI to test-suite component to avoid circular dependencies, and also because it's most suited for them to be there in my opinion * cleaning examples and pom files
* removing a failing case in unit test * fixing pom.xml for build
* removing unnecessay dependency
* fixing tck test * fixing dependencies for tck build * fixing dependencies on sniffer
* moving old build files to archive folder
Collaborator
|
Thanks. I am a litle busy right now. Will try to review this soon. |
|
bump |
Author
|
Hello, |
|
Thanks for this! FWIW, the build instructions given in the README are now outdated and should probably be adjusted to match the changes introduced by this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made some choices regarding names of projects but there's nothing final, everything can be renamed.
I know that the big problem is to keep traces of the modification history, and to my opinion, everything is fine. Though github may not display full history on files that has been moved, but as said here, the problem comes from GitHub not git: #72 (comment) : full history is always available by doing
git log --follow <thefile>(and your favorite IDE usually does the "--follow").