Skip to content

Conversation

@EcksZA
Copy link

@EcksZA EcksZA commented Feb 8, 2016

Good evening Mr Bashir,

I would like to request an addition to your wonderful gem. The requested functionality would:

  • add the ability to add a custom adjective array
  • add the ability to add a custom noun array

Kind regards

@Gerhardk
Copy link

👍

@codered
Copy link

codered commented Feb 25, 2021

how do i get your changes in my branch?

@usmanbashir
Copy link
Owner

@EcksZA I love the functionality for allowing custom nouns and adjectives. But instead of asking the user to send nil as part of the arguments before they can pass what they really want. Can you replace it with an object or another more elegant solution?

That would also simplify your implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants