Refactor code to improve performance and readability.#2
Open
ozfive wants to merge 2 commits intoushis:masterfrom
Open
Refactor code to improve performance and readability.#2ozfive wants to merge 2 commits intoushis:masterfrom
ozfive wants to merge 2 commits intoushis:masterfrom
Conversation
…laces string concatenation with bytes.Buffer to improve efficiency in WriteTo and WriteSimpleTo. It also replaces fmt.Fprintf with strconv.AppendInt for writing integers and uses bufio.Scanner instead of bufio.NewReader for reading lines.
Author
|
Hi @ushis any chance you would like to discuss the pull request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes a license file so that the docs can be viewed again at https://pkg.go.dev/github.com/ushis/m3u since they scan for LICENSE files and don't recognize the MIT license in the code files themselves. It replaces string concatenation with bytes.Buffer to improve efficiency in WriteTo and WriteSimpleTo. It also replaces fmt.Fprintf with strconv.AppendInt for writing integers and uses bufio.Scanner instead of bufio.NewReader for reading lines.