Open
Conversation
On the assert patch it seems like something is failing, I'm suspecting that there's an issue with puppeteer. I might investigate further or just ignore these tests for the time being.
Author
|
@ryanckulp or @schrockwell I can see that this repository is one of the least active in your organization, should I just continue with my own fork? I can understand that it might be too much to spend time on all these projects. |
Contributor
|
thanks @entilldaniel for the nudge and for the work here. we do intend to keep this repo up to date, it's just that this month in particular is crunch time with the imminent X release. but Rockwell can review your work soon and we'll be on our way. appreciate your patience, thank you again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm closing my previous PR since this one fixes all the tests instead.
Hi! First of thank you for creating TRMNL, I'm not a paying customer and at the moment I'm more of a DIY:er so I was hoping to at least give back in some way by taking an interest in this project.
There were some tests that used badly formatted MAC-adresses and other issues that this PR solves.
All the tests should be working now.
Closes #2