Conversation
romanoprid
left a comment
romanoprid
left a comment
There was a problem hiding this comment.
I think it is right.
| alreadySaved ? Icons.favorite : Icons.favorite_border, | ||
| color: alreadySaved ? Colors.red : null, | ||
| alreadySaved ? Icons.done : Icons.attach_money, | ||
| color: alreadySaved ? null : Colors.green, |
There was a problem hiding this comment.
I'm not sure, but if the user taps to save some startup name, the icon will disappear, am I right?
If so, I would instead give the user a possibility to discard their choice, for example.
There was a problem hiding this comment.
I don't recommend using null for colors ever :)
| ), | ||
| body: const Center( | ||
| child: Text( | ||
| "Here you can add your words to the cart. \nYes!!! You can buy them. \n The future is now, wake up", |
There was a problem hiding this comment.
I can't understand the purpose of this page. You can add words to the cart on the first (main) page, but you claim to do the same thing on the info page.
The idea is cool but needs some tuning.
P.S. It would be better to save your text to the constant and then use that constant.
There was a problem hiding this comment.
I think the purpose of this page is to inform users what is on the 'Saved Suggestions' page but not to add words.
There was a problem hiding this comment.
In another pull of requests, I expanded the functionality of the application
There was a problem hiding this comment.
I wouldn't recommend splitting a single feature into multiple PRs in case this feature is small (like yours).
| child: Text( | ||
| "Here you can add your words to the cart. \nYes!!! You can buy them. \n The future is now, wake up", | ||
| style: TextStyle( | ||
| fontSize: 14, color: Colors.black, fontWeight: FontWeight.normal), |
There was a problem hiding this comment.
Doesn't text have a normal font weight by default?
There was a problem hiding this comment.
I'm sure it does (but @Nazarko12 correct me if I'm wrong)
igor-leshkevych
left a comment
igor-leshkevych
left a comment
There was a problem hiding this comment.
@Nazarko12
your feature is a bit "chaotic" (honestly, it was hard for me to understand it), but nevertheless it wasn't a requirement for this lab :)
+5/5 hello world
+3/3 custom feature + PR
Unfortunately, I don't see any code review from you, so you have 0/2 for that.
| alreadySaved ? Icons.favorite : Icons.favorite_border, | ||
| color: alreadySaved ? Colors.red : null, | ||
| alreadySaved ? Icons.done : Icons.attach_money, | ||
| color: alreadySaved ? null : Colors.green, |
There was a problem hiding this comment.
I don't recommend using null for colors ever :)
| ), | ||
| body: const Center( | ||
| child: Text( | ||
| "Here you can add your words to the cart. \nYes!!! You can buy them. \n The future is now, wake up", |
There was a problem hiding this comment.
I wouldn't recommend splitting a single feature into multiple PRs in case this feature is small (like yours).
| child: Text( | ||
| "Here you can add your words to the cart. \nYes!!! You can buy them. \n The future is now, wake up", | ||
| style: TextStyle( | ||
| fontSize: 14, color: Colors.black, fontWeight: FontWeight.normal), |
There was a problem hiding this comment.
I'm sure it does (but @Nazarko12 correct me if I'm wrong)
4 participants
There are some issues with starting the emulator. Therefore, I used a browser to launch the application.
This screen shows simple text output: