mkdocs init #89
Open
mkdocs init #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CGoodwin90
approved these changes
Jun 19, 2023
Member
|
As long as the extensions and plugins are within the same set as the main lagoon repo - https://github.com/uselagoon/lagoon/blob/main/mkdocs.yml You can just reuse the github action there here https://github.com/uselagoon/lagoon/blob/main/.github/workflows/mkdocs.yml |
|
@tobybellwood just noticed this PR is here - is this still good to go? |
timclifford
commented
Feb 6, 2024
| Locally, we can run `make release-test` to check if our changes will build. If compiling was successful we can commit our changes and then run `make release-[patch|minor|major]` to tag with next release number and it will push up to GitHub. A GitHub action will then be triggered which will publish the official release using goreleaser. | ||
|
|
||
| Prior to that, we can locally test our release to ensure that it will successfully build with `make release-test`. If compiling was successful we can commit our changes and then run `make release-[patch|minor|major]` to tag with next release number and it will push up to GitHub. A GitHub action will then be triggered which will publish the official release using goreleaser. | ||
| Locally whhen contributing, we can run `make release-test` to check if our changes will build sucessfully. If compiling was successful we can commit our changes to a new PR ready for review (https://github.com/uselagoon/lagoon-sync/pulls). No newline at end of file |
Contributor
Author
I'd say it might be worth checking locally again first... it's been a while :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.