Update plot_ragtag_paf.R - bug fix#179
Merged
TomHarrop merged 2 commits intousegalaxy-au:masterfrom Sep 15, 2025
Merged
Conversation
bug fix: change all_contig_names from factor to character so all_colours gets correct contig names rather than level numbers
Collaborator
|
Thanks @amytims! I was wondering why this wasn’t working. I’ll just bump the version and run the tests before I merge. |
Collaborator
|
Tests pass locally. @mthang give me a yell if you want me to update the test workflow (or remove it if no-one's using it). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bug fix: changed class of all_contig_names from factor to character so all_colours gets correct contig names rather than level numbers. This gets the reference contig plot colours to follow the viridis colour palette rather than plotting them all in grey and generating the warnings:
Warning messages:
1: No shared levels found between
names(values)of the manual scale and the data's fill values.2: No shared levels found between
names(values)of the manual scale and the data's colour values.