Skip to content

Merogge/status bar #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
uristern123 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Merogge/status bar #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
97d9fcd
fix #227257
meganrogge Sep 6, 2024
591033d
fix #227537
meganrogge Sep 6, 2024
cecac9e
localize
meganrogge Sep 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/vs/workbench/browser/parts/statusbar/statusbarPart.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -712,6 +712,7 @@ export class StatusbarService extends MultiWindowParts<StatusbarPart> implements
statusbarPartContainer.style.position = 'relative';
statusbarPartContainer.setAttribute('aria-live', 'off');
statusbarPartContainer.setAttribute('tabindex', '0');
statusbarPartContainer.setAttribute('aria-label', localize('statusBar', 'Status Bar'));
container.appendChild(statusbarPartContainer);

// Statusbar Part
Expand Down
6 changes: 4 additions & 2 deletions src/vs/workbench/contrib/languageStatus/browser/languageStatus.contribution.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,17 +331,19 @@ class LanguageStatus {

// -- pin
const actionBar = new ActionBar(right, { hoverDelegate: nativeHoverDelegate });
const actionLabel: string = isPinned ? localize('unpin', "Remove from Status Bar") : localize('pin', "Add to Status Bar");
actionBar.setAriaLabel(actionLabel);
store.add(actionBar);
let action: Action;
if (!isPinned) {
action = new Action('pin', localize('pin', "Add to Status Bar"), ThemeIcon.asClassName(Codicon.pin), true, () => {
action = new Action('pin', actionLabel, ThemeIcon.asClassName(Codicon.pin), true, () => {
this._dedicated.add(status.id);
this._statusBarService.updateEntryVisibility(status.id, true);
this._update();
this._storeState();
});
} else {
action = new Action('unpin', localize('unpin', "Remove from Status Bar"), ThemeIcon.asClassName(Codicon.pinned), true, () => {
action = new Action('unpin', actionLabel, ThemeIcon.asClassName(Codicon.pinned), true, () => {
this._dedicated.delete(status.id);
this._statusBarService.updateEntryVisibility(status.id, false);
this._update();
Expand Down