Ночная тема #77
Open
Ночная тема #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
А вот и ночная тема подъехала
Damirikys
requested changes
May 18, 2018
Collaborator
There was a problem hiding this comment.
После перезагрузки все валится: см. в консоль - ReferenceError: document is not defined
Из за метода isDeclarationSupported
Ну и иконку смены темы запилить бы чуть-чуть меньше и в уголок в правый + нужно подключить сюда redux и сделать так, чтобы состояние темы запоминалось и не сбрасывалось при перезагрузке страницы
| @@ -1,7 +0,0 @@ | |||
| PORT=8080 | |||
Collaborator
There was a problem hiding this comment.
Зачем удалил отсюда все?
components/ProfileCard.js
Outdated
| <p className="profile-card__body_bio">{user.bio}</p> | ||
| <p className="profile-card__body_email">{user.email}</p> | ||
| </div> | ||
| <ThemeSwitch></ThemeSwitch> |
| } | ||
| } | ||
|
|
||
| ThemeSwitch.defaultProps = { |
Collaborator
There was a problem hiding this comment.
пропсы у нас по другому декларируются:
type Props = {
...
}
class ThemeSwitch extends Component<Props> {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
А вот и ночная тема подъехала