Ильиных Анна #16
Open
Ильиных Анна #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zhigalov
reviewed
May 14, 2018
Zhigalov
left a comment
Zhigalov
left a comment
There was a problem hiding this comment.
Хорошо, ты правильно проверила выигрыш и ничью. Молодец.
Хотелось бы увидеть тесты на игровую механику:
- если удачно сходил крестик, то следующий ходит нолик
- если неудачно сходил крестик (по ячейке, на которой уже есть отметка), то следующий ходит тоже крестик
Проверить, что кнопка очищает игровое поле.
| function startNewGame(fieldInputs) { | ||
| playingFieldInputs.forEach(input => { | ||
| input.removeAttribute('value'); | ||
| }); |
There was a problem hiding this comment.
playingFieldInputs.forEach(input => input.removeAttribute('value'));
|
Аня, по этой задаче нужны доработки |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.