This repository was archived by the owner on Jan 27, 2025. It is now read-only.
feature: separate action bar renderer#188
Open
tmarcinkowski-logitech wants to merge 1 commit intouptick:masterfrom
Open
feature: separate action bar renderer#188tmarcinkowski-logitech wants to merge 1 commit intouptick:masterfrom
tmarcinkowski-logitech wants to merge 1 commit intouptick:masterfrom
Conversation
Contributor
|
Hello 👋 I'd like for all PRs to follow a template going forward to help with keeping track :) Other then that the PR name format should be the following. |
Contributor
Author
I've updated all my PRs ;) BTW you're sure you mean feature (full wording) instead of feat like in Conventional Commits? |
Contributor
|
Thank you 🔥 and I prefer |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I have extracted existing markup wrapping both actions and filtered rendered into separate ActionBar renderer. I needed more flexibility to style this the way I wanted.
Changelog
How Has This Been Tested?
Checklist: