Skip to content

Use JSON.parse/stringify to clone an object#17

Open
p3k wants to merge 1 commit intoupphiminn:masterfrom
weblyzard:error-in-clone-no-constructor-function
Open

Use JSON.parse/stringify to clone an object#17
p3k wants to merge 1 commit intoupphiminn:masterfrom
weblyzard:error-in-clone-no-constructor-function

Conversation

@p3k
Copy link
Copy Markdown

@p3k p3k commented Aug 21, 2024

We noticed that the clone() function can cause an error if the constructor property is not a function.

This is a (rare?) case when a POJO has a property named constructor:

{
   "building": "House A",
   "constructor": "Construction Company Ltd."
}

This PR replaces the main part of the clone() function with the JSON.parse/stringify combo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant