Open
Conversation
Author
|
By the way, thank you for making this library. |
upphiminn
reviewed
Jul 3, 2020
| } else { | ||
| edge_index[key] = graph.edges.length; | ||
| graph.edges.push(edge); | ||
| edge_index[edge.source + '_' + edge.target] = graph.edges.length - 1; |
Owner
There was a problem hiding this comment.
I don't quite understand why you think this is wrong? Indexes shouldn't go up to length; otherwise the other changes look fine :)
Author
There was a problem hiding this comment.
Oh, this logic is not wrong at all. It's just that subtracting 1 seemed a bit redundant since we can get the same value from graph.edges.length prior to adding the edge to graph.edges.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug when creating the induced graph, in which the first edge of the induced graph (with index 0) can end up being duplicated instead of having its weight updated.