Open
Conversation
This commit is a step towards resolving the response header warning: `Warning: 199 Miscellaneous warning: Please use API version 0.7, not 0.6` It will also help resolve nil pointer errors when accessing files.ContentInfo, which requires APIv0.7.
Given the warnings being returned by the REST API when using any version < v0.7, we should set the `defaultAPIVersion` to the latest version (v0.7)
onsi/gomega#467 broke the tests here. See discussion: onsi/gomega#488 Upgrading the go version fixes the issue.
Member
|
Hi. But what about changes that might break lib behaviour? E.g.:
This change might work for you, but might also be a breaking for somebody else. :-( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In the current state this SDK does not allow users to benefit from the changes in the REST API v0.7.
We have recently run into an issue where we added a PDF via a link. The links MIME type was
application/octet-streamwhich was saved as the MIME type in Uploadcare. TheContentInfoobject contains the correct/expected MIME type ofapplication/pdf. However, using this SDK we were unable to access these fields since the SDK uses v0.5 by default and v0.6 if configured.No open issue around this, but I have just encountered an issue with trying to access
file.ContentInfo.defaultAPIVersionto v0.7 from v0.5.Enables support for new fields added to the REST API since v0.5.
Checklist