Fix compose objs #13
Merged
Fix compose objs #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
So this is the only way I found to make things work. I put back Enumerable, otherwise it enforces us to us an array as input but we lose ActiveRecord relations (not sure of me, but couldn't serialize nested objects). I've added a new case for Hashes to use @tgallice @AlexisMontagne What do you think about that ? |
| if obj.is_a? Array | ||
| ArraySerializer.new(obj, opts) | ||
| else | ||
| if obj.is_a?(Hash) || !obj.is_a?(Enumerable) |
There was a problem hiding this comment.
I think should wrap most of the cases, but if we have a Nil class passed here, it will jump inside of this if.
Should we consider this scenario?
Contributor
Author
There was a problem hiding this comment.
I think it is the same behaviour as before. There was an else that would catch everything else including Nil class.
upfluence-bot
added
reviewed/needs-work
and removed
reviewed/needs-review
reviewed/needs-work
labels
pauloestrella1994
approved these changes
Jul 16, 2025
AlexisMontagne
approved these changes
Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
What are the observable changes?
Good PR checklist
Additional Notes