base_serializer: Rename attributes/relations to avoid conflict #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexisMontagne
approved these changes
Jun 27, 2025
Member
AlexisMontagne
left a comment
AlexisMontagne
left a comment
There was a problem hiding this comment.
Can you update the test file and use https://github.com/upfluence/actions/blob/master/.github/workflows/lib-ruby-test.yml ?
upfluence-bot
added
reviewed/ready-to-merge
reviewed/needs-review
and removed
reviewed/needs-review
reviewed/ready-to-merge
labels
tgallice
force-pushed
the
tg/rename_attributes_relations
branch
from
d0272b8 to
d71da04
Compare
xgoffin
approved these changes
Jun 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Rename private method
attributesto_attributesandrelationsto_relationsto avoid conflictGood PR checklist
Additional Notes