Support zero values for skins in the OSS::ProgressBar #629
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
This is the final PR Bugbot will review for you during this billing cycle
Your free Bugbot reviews will reset on February 28
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
|
|
||
| test('if the value is defined, the progress bar has the correct pending value', async function (assert) { | ||
| await render(hbs`<OSS::ProgressBar @value={{this.checkedValue}} @skins={{this.skins}} />`); | ||
| await render(hbs`<OSS::ProgressBar @skins={{this.skins}} />`); |
There was a problem hiding this comment.
we are removing the @value argument as it isn't used when using "skin-mode" right ?
There was a problem hiding this comment.
Yes, @skins type is skins?: Partial<Record<ProgressBarSkins, number>>;. This is due to a copy/paste error when writing the tests for @skins. When passing @skins, the @value is not read.
upfluence-bot
added
reviewed/ready-to-merge
reviewed/needs-work
and removed
reviewed/ready-to-merge
labels
What does this PR do?
Support zero values for skins in the OSS::ProgressBar
What are the observable changes?
Screencast.from.2026-01-29.09-49-52.webm
Good PR checklist
Note
Low Risk
Small template-only rendering change plus test/demo updates; minimal behavior impact outside the 0%-skins edge case.
Overview
Ensures
OSS::ProgressBarcorrectly renders a multi-skin bar when all@skinsvalues sum to0by outputting a single empty segment instead of rendering no segments.Updates the visual dummy page with explicit 0% multi-segment examples, and adjusts/extends integration tests (including a new assertion for the 0% empty-bar style) while removing unnecessary
@valueusage when@skinsis provided.Written by Cursor Bugbot for commit 61f35aa. This will update automatically on new commits. Configure here.